2
Vote

Bugs in NMEA sentence constructors

description

There are a number of bugs in the NMEA sentence constructors (e.g. GPGGA, GPGSV, GPGSA, etc.) where, if the sentence is constructed from passed params rather than a string, the constructor uses the member params instead of the passed params. A specific example is the GPGSA sentence constructor which accepts FixMode and FixMethod, but then ignores them.

comments

BigstickCarpet wrote Mar 29, 2010 at 12:57 PM

I've noticed this same problem across the project. There are many properties, events, parameters, and methods that are clearly meant to be used, but actually aren't. I think this is the result of a major refactoring that was done when the project was converted from commercial to open-source. I've been fixing them one-by-one as I come across them, but I certainly appreciate your help in pointing them out.

I'll fix the issues you've mentioned here in my next code commit.

wrote Feb 21, 2013 at 10:51 PM